Skip to content

Fix zmachine challenge for the gpu #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix zmachine challenge for the gpu #3934

merged 1 commit into from
Feb 25, 2025

Conversation

AhmedHanafy725
Copy link
Contributor

Description

  • Fix zmachine challenge for the gpu

Related Issues

Tested Scenarios

  • deploy a full vm with gpu and 2 env vars

@0oM4R
Copy link
Contributor

0oM4R commented Feb 24, 2025 •
edited
Loading

I tried to deploy on node 171 on dashboard:

  • the node is listed normally and reserve button is shown; i select the gpu card clicked deploy got an error node 171 is not rented by the current user;

  • i reserved the node selected the card clicked deploy; the deployment was successful in logs, but i got

    telegram-cloud-photo-size-4-5900100216827266561-y
    this is maybe related to deployment details [ accessing deployment details to show it in details]

  • the contracts was listed in contracts page but i couldn't show the details,

  • after that the node no longer be listed in node automatic selector so i tried to delete my rent contract; after that i notice that the node is not healthy

telegram-cloud-photo-size-4-5900100216827266565-y

@0oM4R 0oM4R closed this Feb 24, 2025
@0oM4R 0oM4R reopened this Feb 24, 2025
@scottyeager
Copy link
Contributor

Hi @0oM4R, I don't think the issue you experienced is related to this change. Personally I tested the same change from this PR with success.

Maybe the issue you saw was actually with the node itself?

@mik-tf
Copy link
Contributor

mik-tf commented Feb 25, 2025

I confirm on my end: I modified the files as in this PR, so the env vars work with GPU and it does work. See: fd51940

So as I understand the fix is working.

@AhmedHanafy725 AhmedHanafy725 merged commit acd3c6f into development Feb 25, 2025
12 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_vm_challenge branch February 25, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader xmonader approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AhmedHanafy725 @0oM4R @scottyeager @mik-tf @xmonader